React Native Implement Basic text Toolbar actions #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return accFormats; | ||
| }, {} ); | ||
|
|
||
| this.setState( { newFormats, selectedNodeId: this.state.selectedNodeId + 1 } ); |
There was a problem hiding this comment.
Wonder why it's needed selectedNodeId: this.state.selectedNodeId + 1 here.
There was a problem hiding this comment.
copy pasted from the GB web... @gziolo you know why is this?
| @@ -21,12 +21,20 @@ import { children } from '@wordpress/blocks'; | |||
| import FormatToolbar from './format-toolbar'; | |||
| import { FORMATTING_CONTROLS } from './formatting-controls'; | |||
|
|
|||
| export function getFormatValue( formatName ) { | |||
There was a problem hiding this comment.
@gziolo I wonder why we need to export this function here. Can 't it be moved in RichText component since it's only used there?
There was a problem hiding this comment.
I think it is exported only to be used in tests
daniloercoli
approved these changes
Aug 23, 2018
|
Looks good, let's iterate on |
gziolo
approved these changes
Aug 24, 2018
gziolo
added
the
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: wordpress-mobile/gutenberg-mobile#128
This PR implements the connection of the toolbar with the richtext component in React Native.
How has this been tested?
Screenshots
Types of changes
Checklist: